feat: hot reload eszip bundle when function source changes #3710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweatybridge
force-pushed
the
watch-serve
branch
from
fb132b0 to
1e15490
Compare
sweatybridge
force-pushed
the
watch-serve
branch
2 times, most recently
from
c226f2b to
cf62e9a
Compare
sweatybridge
force-pushed
the
watch-serve
branch
from
cf62e9a to
e235a49
Compare
sweatybridge
force-pushed
the
watch-serve
branch
from
815e518 to
b58b235
Compare
* chore: add watcher tests and main.ts * chore: add serve tests * chore: fix lints * chore: remove sleep in tests * chore: simulate fs event when possible * chore: avoid flaky tests * chore: undo debounce test --------- Co-authored-by: Qiao Han <[email protected]>
sweatybridge
force-pushed
the
watch-serve
branch
from
da4b080 to
b0eefa6
Compare
sweatybridge
changed the title
avallete
approved these changes
Jun 17, 2025
| if watcher := runtimeOption.fileWatcher; watcher != nil { | ||
| var watchPaths []string | ||
| for _, b := range binds { | ||
| if spec, err := loader.ParseVolume(b); err != nil { |
There was a problem hiding this comment.
praise
Nice re-use of docker api.
sweatybridge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.